refactor: constructor functions

2023-12-26 09:16:21 +01:00
parent 1371889d6d
commit 624a269454
3 changed files with 141 additions and 89 deletions
@@ -57,106 +57,92 @@ func TestMockSendEmail(t *testing.T) {
 	}
 }

-func TestSendEmail(t *testing.T) {
+func TestNewInsecure(t *testing.T) {
 	cfg := newConfig(".env.test")

-	mailSrv := NewMailService(MailServiceConfig{
+	mailSrv := NewInsecure(MailServiceConfig{
 		Auth: smtp.PlainAuth("", cfg.MailUser, cfg.MailPassword, cfg.MailHost),
 		Host: cfg.MailHost,
 		Port: cfg.MailPort,
 		From: cfg.MailFrom,
 	})

-	data := EmailMessage{
-		To:      cfg.MailTo,
-		Subject: "Mail Sender",
-		Body:    "Hello this is a test email",
-	}
-	require.NoError(t, mailSrv.SendEmail(data))
-}
-
-func TestSendEmail_FailedAuthentication(t *testing.T) {
-	cfg := newConfig(".env.test")
-	// set up authentication to fail
-	mailSrv := NewMailService(MailServiceConfig{
-		Auth: smtp.PlainAuth("", "wronguser", "wrongpassword", cfg.MailHost),
-		Host: cfg.MailHost,
-		Port: cfg.MailPort,
-		From: cfg.MailFrom,
+	t.Run("TestSendEmail", func(t *testing.T) {
+		data := EmailMessage{
+			To:      cfg.MailTo,
+			Subject: "Mail Sender",
+			Body:    "Hello this is a test email",
+		}
+		require.NoError(t, mailSrv.SendEmail(data))
 	})
-	data := EmailMessage{
-		To:      cfg.MailTo,
-		Subject: "Test Email",
-		Body:    "This is a test email.",
-	}
-	err := mailSrv.SendEmail(data)
-	assert.Error(t, err)
-}

-func TestSendEmail_InvalidRecipient(t *testing.T) {
-	cfg := newConfig(".env.test")
-	mailSrv := NewMailService(MailServiceConfig{
-		Auth: smtp.PlainAuth("", cfg.MailUser, cfg.MailPassword, cfg.MailHost),
-		Host: cfg.MailHost,
-		Port: cfg.MailPort,
-		From: cfg.MailFrom,
+	t.Run("TestSendEmailWithAttachments", func(t *testing.T) {
+		reader, err := os.Open("testdata/attachment1.txt")
+		require.NoError(t, err)
+		defer reader.Close()
+
+		reader2, err := os.Open("testdata/attachment2.txt")
+		require.NoError(t, err)
+		defer reader2.Close()
+
+		reader3, err := os.Open("testdata/attachment3.txt")
+		require.NoError(t, err)
+		defer reader3.Close()
+
+		data := EmailMessage{
+			To:      cfg.MailTo,
+			Subject: "Mail Sender",
+			Body:    "Hello this is a test email",
+			Attachments: []EmailAttachment{
+				{
+					Title: "attachment1.txt",
+					File:  reader,
+				},
+				{
+					Title: "attachment2.txt",
+					File:  reader2,
+				},
+				{
+					Title: "attachment3.txt",
+					File:  reader3,
+				},
+			},
+		}
+		err = mailSrv.SendEmail(data)
+		require.NoError(t, err)
 	})
-	data := EmailMessage{
-		To:      "invalid_email",
-		Subject: "Test Email",
-		Body:    "This is a test email.",
-	}
-	err := mailSrv.SendEmail(data)
-	assert.Error(t, err)
-}

-func TestSendEmailWithAttachments(t *testing.T) {
-	cfg := newConfig(".env.test")
-
-	mailSrv := NewMailService(MailServiceConfig{
-		Auth: smtp.PlainAuth("", cfg.MailUser, cfg.MailPassword, cfg.MailHost),
-		Host: cfg.MailHost,
-		Port: cfg.MailPort,
-		From: cfg.MailFrom,
+	t.Run("TestWithAttachments", func(t *testing.T) {
+		msg := newMessage("from", "to", "subject")
+		content, err := msg.withAttachments("body", nil)
+		require.NoError(t, err)
+		assert.Greater(t, len(content), 0)
 	})
-	reader, err := os.Open("testdata/attachment1.txt")
-	require.NoError(t, err)
-	defer reader.Close()

-	reader2, err := os.Open("testdata/attachment2.txt")
-	require.NoError(t, err)
-	defer reader2.Close()
+	t.Run("TestSendEmail_InvalidRecipient", func(t *testing.T) {
+		data := EmailMessage{
+			To:      "invalid_email",
+			Subject: "Test Email",
+			Body:    "This is a test email.",
+		}
+		err := mailSrv.SendEmail(data)
+		assert.Error(t, err)
+	})

-	reader3, err := os.Open("testdata/attachment3.txt")
-	require.NoError(t, err)
-	defer reader3.Close()
-
-	data := EmailMessage{
-		To:      cfg.MailTo,
-		Subject: "Mail Sender",
-		Body:    "Hello this is a test email",
-		Attachments: []EmailAttachment{
-			{
-				Title: "attachment1.txt",
-				File:  reader,
-			},
-			{
-				Title: "attachment2.txt",
-				File:  reader2,
-			},
-			{
-				Title: "attachment3.txt",
-				File:  reader3,
-			},
-		},
-	}
-	err = mailSrv.SendEmail(data)
-	require.NoError(t, err)
-}
-
-func TestWithAttachments(t *testing.T) {
-	msg := newMessage("from", "to", "subject")
-	content, err := msg.withAttachments("body", nil)
-	require.NoError(t, err)
-	assert.Greater(t, len(content), 0)
+	t.Run("TestSendEmail_FailedAuthentication", func(t *testing.T) {
+		// set up authentication to fail
+		mailSrv := NewInsecure(MailServiceConfig{
+			Auth: smtp.PlainAuth("", "wronguser", "wrongpassword", cfg.MailHost),
+			Host: cfg.MailHost,
+			Port: cfg.MailPort,
+			From: cfg.MailFrom,
+		})
+		data := EmailMessage{
+			To:      cfg.MailTo,
+			Subject: "Test Email",
+			Body:    "This is a test email.",
+		}
+		err := mailSrv.SendEmail(data)
+		assert.Error(t, err)
+	})
 }